Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take minimum_makers config var value into account on Send page #101

Closed
theborakompanioni opened this issue Feb 15, 2022 · 0 comments · Fixed by #116
Closed

Take minimum_makers config var value into account on Send page #101

theborakompanioni opened this issue Feb 15, 2022 · 0 comments · Fixed by #116
Assignees
@theborakompanioni
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
v0.0.5 - Sweep Sw...

Comments

@theborakompanioni
Copy link
Collaborator

When initiating a collaborative transaction the number of collaborators can be provided.
It seems, based on these comments, this value must not be less than what is specified in config variable minimum_makers. Default is 4.

A viable solution is to GET the value of this variable and use it as min value for the form on the Send page.
@theborakompanioni theborakompanioni added bug Something isn't working good first issue Good for newcomers labels Feb 15, 2022
@dergigi dergigi mentioned this issue Feb 17, 2022
Open
@theborakompanioni theborakompanioni self-assigned this Feb 21, 2022
@theborakompanioni theborakompanioni mentioned this issue Feb 21, 2022
Merged
@dergigi dergigi added this to JAM Feb 22, 2022
@dergigi dergigi moved this to Todo 📝 in JAM Feb 22, 2022
@ghost ghost closed this as completed in #116 Feb 22, 2022
Repository owner moved this from Todo 📝 to Done ✅ in JAM Feb 22, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theborakompanioni theborakompanioni

Labels
bug Something isn't working good first issue Good for newcomers
Projects
JAM
Status: Done ✅
Milestone
v0.0.5 - Sweep Sweep Jam
Development

Successfully merging a pull request may close this issue.

Take minimum_makers config var value into account on Send page joinmarket-webui/jam
1 participant
@theborakompanioni