Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(faq): info about wallet import via UI #48

Closed
wants to merge 3 commits into from

Conversation

theborakompanioni
Copy link
Collaborator

Adds the following section to the FAQ page:

Yes, importing an existing wallet can be done via the web interface since Jam v0.1.6.
Just make sure you are running JoinMarket v0.9.10 or later.

The previously existing paragraph has been moved to "How to import wallets via the command line?".

@theborakompanioni theborakompanioni added the documentation Improvements or additions to documentation label Sep 23, 2023
@theborakompanioni theborakompanioni self-assigned this Sep 23, 2023
@theborakompanioni
Copy link
Collaborator Author

ping @dergigi

docs/FAQ.md Show resolved Hide resolved
docs/FAQ.md Outdated Show resolved Hide resolved
@MarnixCroes
Copy link
Collaborator

what's up with this?
can't be merged? :D

@theborakompanioni theborakompanioni requested a review from a team December 5, 2023 16:13
@theborakompanioni
Copy link
Collaborator Author

what's up with this? can't be merged? :D

Hey @MarnixCroes, thanks for asking and the reminder.
It needs approval from one of the maintainers, e.g. @dergigi.
My hands are tied.

@MarnixCroes
Copy link
Collaborator

I see.
maybe as a work around, I can cherry-pick your commit and create a PR.
If there is still no reply from gigi (in a week?).
as you can merge other's pr's but not your own right.

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented Dec 6, 2023

[...] I can cherry-pick your commit and create a PR. [...] as you can merge other's pr's but not your own right.

I am not sure. It would be strange if that worked. But I am thrilled by your creativity. : D

Edit: Yes, it will work. Just verified with your PR #51. 🙌

@theborakompanioni
Copy link
Collaborator Author

Superseded by #52.
Thanks you @MarnixCroes 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants