Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: new joining indicator symbol #849

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Sep 12, 2024

Changes the symbol if a maker or taker process is started.

Also fixes a small navlink positioning issue in the side menu on mobile screens.

📸

Before

After

@theborakompanioni theborakompanioni added concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience labels Sep 12, 2024
@theborakompanioni theborakompanioni self-assigned this Sep 12, 2024
@theborakompanioni theborakompanioni marked this pull request as ready for review September 13, 2024 09:29
Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

symbol should also be updated at send

<Sprite className="ms-auto" symbol="joining" width="20" height="20" />

sc

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 89f9f64

@theborakompanioni
Copy link
Collaborator Author

ping @editwentyone.. just a concept. 👍 / 👎 ?

@theborakompanioni theborakompanioni merged commit 343d40e into devel Sep 17, 2024
1 check passed
@theborakompanioni theborakompanioni deleted the fix/jamming-symbol branch September 17, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants