Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small quick freeze modal adaptions #847

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Sep 12, 2024

This PR tries to enhance the phrasing in the Quick Freeze and Payment Confirm modal on the Send page.
Distinction is done between "Eligible UTXOs" (for non-sweeps) and "Selected UTXOs" (for sweeps).
Please let me know what you think - feedback is desperately needed!
Also, if you have better versions of the texts and phrases in mind - please post them here as comment or as change suggestion! 🙏

Quick Freeze Confirm Modal

  • Visually adjust the "confirmations" block
  • Title from "Select UTXOs to be considered" to just "Select UTXOs"
  • Phrase "The following UTXOs are considered in the transaction. " to one of the following
    "subtitle_zero": "Please select one or more UTXOs for possible inclusion in the transaction.",
    "subtitle_one": "The selected UTXO is eligible for inclusion in the transaction.",
    "subtitle_other": "The selected UTXOs are eligible for inclusion in the transaction.",
  • Phrase "Every unselected UTXO will be frozen and can be unfrozen later on." to "Unselected UTXOs will be frozen and can be unfrozen later anytime."

Payment Confirm Modal

  • Non-sweep sends with more than one UTXO use label "Considered UTXOs" "Eligible UTXOs"
    • With description "One or more of the following UTXOs will be included in the transaction: "
  • Sweeps or non-sweep sends with single UTXOs use label "Selected UTXOs"
    • With description:
      • Either "The following UTXO will be included in the transaction: " (single UTXO)
      • Or "The following UTXOs will be included in the transaction: " (multple UTXOs)

📸 Screenshots (already outdated)


@theborakompanioni theborakompanioni added the UI/UX Issue related to cosmetics, design, or user experience label Sep 12, 2024
@theborakompanioni theborakompanioni self-assigned this Sep 12, 2024
@theborakompanioni theborakompanioni marked this pull request as ready for review September 17, 2024 12:09
@theborakompanioni
Copy link
Collaborator Author

ping @editwentyone

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

nit, maybe this one can adapt to single or plural too?
image

"text_select_utxos_tooltip": "Select UTXOs",
"title": "Select eligible UTXOs",
"subtitle_zero": "Please select one or more UTXOs for possible inclusion in the transaction.",
"subtitle_one": "The selected UTXO is eligible for inclusion in the transaction.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the matching with the subtitle_other, but it reads a bit weird imo "is eligible for inclusion" as it will for sure be included,
maybe something like The selected UTXO will be used in the transaction.

Copy link
Collaborator Author

@theborakompanioni theborakompanioni Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I open to any suggestion. However, doesn't

The selected UTXO will be used in the transaction.

sound more like it will "definitely used" in the transaction than the other phrase ("eligible for inclusion")?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh.. okay. Now I think I get what you mean. If only one UTXO is selected, it will of course be included, yes?
Good point! I am not sure if the phrasing should change so "suddenly" when a user ticks some boxes in this component as it is just for quickly freezing/unfreezing..

I think @editwentyone might have good inputs to this also.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarnixCroes I can't tell right now what is the best way, I would try to avoid the switching during selecting. lets see when we keep it like this first and then we can adjust it in another PR if needed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarnixCroes Okay for you if it is merged the way it is currently?
I think it the context of "quickly freezing/unfreezing UTXOs", phrasing it this way is "okay".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MarnixCroes - if it is okay for you, I'll merge this soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I missed this.
yes sure it's ok

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented Sep 17, 2024

cACK

nit, maybe this one can adapt to single or plural too?

Yep! Done! Thank you 🙏

@theborakompanioni theborakompanioni merged commit 5664320 into devel Sep 30, 2024
1 check passed
@theborakompanioni theborakompanioni deleted the fix/quick-freeze-followup branch September 30, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants