perf: optimize api request #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
force-pushed
the
perf/optimize-fetch
branch
from
419f2fd to
09cf5a5
Compare
|
ping @editwentyone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to prevent fetching UTXO labels when it is not strictly necessary.
The request to
/displayis quite expensive for heavily used wallets and users report it can take up to several minutes!On initially unlocking a wallet the request is made at least once. After that, it will only be done when there is no label present for a UTXO returned in the
/utxoendpoint response.How to test?
Do some transactions and verify that the new UTXOs all have the correct label attached. e.g.
deposit,cj-out, etc./displayrequests previously always executed in the Jar Details Modal and the Send page.