-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and DRYer code #821
Merged
theborakompanioni
merged 15 commits into
devel
from
796-ui-confirmation-modal-before-starting
Aug 28, 2024
Merged
Refactor and DRYer code #821
theborakompanioni
merged 15 commits into
devel
from
796-ui-confirmation-modal-before-starting
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xSaksham
requested review from
theborakompanioni,
editwentyone,
barrytra and
amitx13
August 24, 2024 11:49
hey @theborakompanioni now this PR will block my workflow. Please review and merge it as soon as you get time. |
@theborakompanioni all the changes that we talked about are done, please review this PR if you get time. Thanks! |
theborakompanioni
approved these changes
Aug 28, 2024
theborakompanioni
deleted the
796-ui-confirmation-modal-before-starting
branch
August 28, 2024 11:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Suggested changes
Start Scheduler
ButtonFuture Goals