fix: default for collaborators set to 1 and added dev tag

[nischal-shetty2]

Fixes #780

previously the default number of collaborators was randomised between 8-10, which would cause the collaboration transaction to fail. This PR fixes this issue by setting the default value of collaborations to 1 and adds a dev tag as a visual hint.

now if we directly send with 1 collaborator selected by default the transaction succeeds as expected.

Screen.Recording.2024-08-21.at.11.26.52.PM.mov

[theborakompanioni]

previously the default number of collaborators was randomised between 8-10, which would cause the collaboration transaction to fail. This PR fixes this issue by setting the default value of collaborations to 1 and adds a dev tag as a visual hint.

Hey @nischal-shetty2! Nice! Thanks for the contribution!

One additional change request is to only apply this when the app is in "dev mode" (as stated in the linked issue).
You can use isDevMode from src/constants/debugFeatures.ts! Would that be possible?

[nischal-shetty2]

One additional change request is to only apply this when the app is in "dev mode" (as stated in the linked issue). You can use isDevMode from src/constants/debugFeatures.ts! Would that be possible?

Sure i can do that right away!

[nischal-shetty2]

Hey @nischal-shetty2! Nice! Thanks for the contribution!

This is my first contribution to this repo, and even though it's a small one, I'm glad to start somewhere.
@theborakompanioni, are there any other changes needed?

[theborakompanioni]

Hey @nischal-shetty2! Nice! Thanks for the contribution!

This is my first contribution to this repo, and even though it's a small one, I'm glad to start somewhere. @theborakompanioni, are there any other changes needed?

@nischal-shetty2 I do not think the "dev" tag is needed, because this feature is also available in production. Should it be removed? What do you think?

Also, can we use undefined (not '' empty string) for customNumCollaboratorsInput when a user did not touch the input field yet?

[nischal-shetty2]

I do not think the "dev" tag is needed, because this feature is also available in production. Should it be removed? What do you think?

@theborakompanioni yes, if this is the case in production as well then its definitely not required! I think it would be best not to show the dev tag

Also, can we use undefined (not '' empty string) for customNumCollaboratorsInput when a user did not touch the input field yet?

on it!

[nischal-shetty2]

@theborakompanioni made the changes, could you review it now!

[theborakompanioni]

@theborakompanioni made the changes, could you review it now!

Made some small changes move the dependency on isDevMode from CollaboratorsSelector to the parent component. Other than that, looks good to me! 🚀

Can you review the changes and verify they work properly on your side as well? Start once with npm run dev:start (changes should apply) and once with npm run start (changes should not apply).

[nischal-shetty2]

Can you review the changes and verify they work properly on your side as well? Start once with npm run dev:start (changes should apply) and once with npm run start (changes should not apply).

tested it locally on both dev as well as prod and works perfectly! This can be merged now if everything is good!

@theborakompanioni although i noticed one more thing unrelated to this issue, on the Collaborator fees title

is it supposed to be '...' or does it have to show the value like how Number of collaborators title shows us current selected number

[theborakompanioni]

Can you review the changes and verify they work properly on your side as well? Start once with npm run dev:start (changes should apply) and once with npm run start (changes should not apply).

tested it locally on both dev as well as prod and works perfectly! This can be merged now if everything is good!

💪

@theborakompanioni although i noticed one more thing unrelated to this issue, on the Collaborator fees title is it supposed to be '...' or does it have to show the value like how Number of collaborators title shows us current selected number

This should change to something meaningful as soon as you input an amount!

[nischal-shetty2]

This should change to something meaningful as soon as you input an amount!

yes yes got it, my bad i didnt input the amount field