Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SchedulerConfirmationModal.tsx #817

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Update SchedulerConfirmationModal.tsx #817

merged 1 commit into from
Aug 20, 2024

Conversation

0xSaksham
Copy link
Contributor

minor production error

@0xSaksham
Copy link
Contributor Author

just had to change showCloseButton to closeButton. This PR fixes that!

@0xSaksham 0xSaksham self-assigned this Aug 20, 2024
@0xSaksham 0xSaksham added the refactoring Code refactoring without functional changes label Aug 20, 2024
@0xSaksham
Copy link
Contributor Author

This may break devel branch!!

@0xSaksham
Copy link
Contributor Author

I just merged the PR #796 and devel branch showed an error which was easy to fix.

But now it requires a review to merge this very small change!

barrytra
barrytra approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@barrytra barrytra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was exactly stuck on this while reviewing a PR. This fixes the error :)

@barrytra barrytra merged commit cb3b430 into devel Aug 20, 2024
@barrytra barrytra deleted the 0xSaksham-patch-1 branch August 20, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrytra barrytra barrytra approved these changes

@theborakompanioni theborakompanioni Awaiting requested review from theborakompanioni

@editwentyone editwentyone Awaiting requested review from editwentyone

@amitx13 amitx13 Awaiting requested review from amitx13

Assignees

@0xSaksham 0xSaksham

Labels
refactoring Code refactoring without functional changes
Projects
JAM
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSaksham @barrytra