Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependencies #813

Merged
merged 2 commits into from
Aug 20, 2024
Merged

build(deps): update dependencies #813

merged 2 commits into from
Aug 20, 2024

Conversation

theborakompanioni
Copy link
Collaborator

Update dependencies

     husky            ^8.0.3  →    ^9.1.4
     i18next        ^23.11.4  →  ^23.13.0
     lint-staged     ^14.0.1  →   ^15.2.9
     prettier         ^3.2.5  →    ^3.3.3
     react-i18next   ^14.1.1  →   ^15.0.1
     @emotion/react          ^11.11.4  →  ^11.13.0
     @types/react             ^18.3.2  →   ^18.3.3
     formik                    ^2.4.5  →    ^2.4.6
     qrcode                    ^1.5.3  →    ^1.5.4
     react-bootstrap           ^2.9.2  →   ^2.10.4
     react-router-bootstrap   ^0.26.2  →   ^0.26.3
     react-router-dom         ^6.23.1  →   ^6.26.1

@theborakompanioni theborakompanioni added the dependencies Pull requests that update a dependency file label Aug 17, 2024
@theborakompanioni theborakompanioni self-assigned this Aug 17, 2024
@@ -53,7 +53,7 @@
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject",
"postinstall": "husky install",
"prepare": "husky",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While only installing dependencies, this can fail as husky wouldn't be installed. Are you sure we want that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik prepare runs after install. Tested with a fresh clone and everything seems to work.
This is the recommended approach from https://github.com/typicode/husky/releases/tag/v9.0.1

 @emotion/react          ^11.11.4  →  ^11.13.0
 @types/react             ^18.3.2  →   ^18.3.3
 formik                    ^2.4.5  →    ^2.4.6
 qrcode                    ^1.5.3  →    ^1.5.4
 react-bootstrap           ^2.9.2  →   ^2.10.4
 react-router-bootstrap   ^0.26.2  →   ^0.26.3
 react-router-dom         ^6.23.1  →   ^6.26.1
 husky            ^8.0.3  →    ^9.1.4
 i18next        ^23.11.4  →  ^23.13.0
 lint-staged     ^14.0.1  →   ^15.2.9
 prettier         ^3.2.5  →    ^3.3.3
 react-i18next   ^14.1.1  →   ^15.0.1
Copy link
Contributor

@barrytra barrytra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow seems fine and all tests passed. Approved!!

@theborakompanioni theborakompanioni merged commit 962dc87 into devel Aug 20, 2024
@theborakompanioni theborakompanioni deleted the deps branch August 20, 2024 08:13
0xSaksham added a commit that referenced this pull request Aug 21, 2024
* fix: amount input field to properly interpret BTC (#800)

* feat: add SchedulerConfirmationModal component for starting scheduled sweep (#803)

* feat: add SchedulerConfirmationModal component for starting scheduled sweep

* removed dead code

* modal is centered and design changes

* used ConfirmModal and pre-written styles

* refactor: SchedulerConfirmationModal.tsx

minor production error

* build(deps): update dependencies (#813)

 @emotion/react          ^11.11.4  →  ^11.13.0
 @types/react             ^18.3.2  →   ^18.3.3
 formik                    ^2.4.5  →    ^2.4.6
 qrcode                    ^1.5.3  →    ^1.5.4
 react-bootstrap           ^2.9.2  →   ^2.10.4
 react-router-bootstrap   ^0.26.2  →   ^0.26.3
 react-router-dom         ^6.23.1  →   ^6.26.1
 husky            ^8.0.3  →    ^9.1.4
 i18next        ^23.11.4  →  ^23.13.0
 lint-staged     ^14.0.1  →   ^15.2.9
 prettier         ^3.2.5  →    ^3.3.3
 react-i18next   ^14.1.1  →   ^15.0.1

* refactor: align utxo list and modal components (#815)

* refactor: externalize UtxoIcon component and utxoTags function

* refactor: externalize UtxoConfirmations component

* refactor: reuse utxo icons in Jar details and UTXO list

* refactor(ui): simpler checkbox in utxo list

* refactor(send): vertically align balance

* refactor(send): tooltip for shortened addresses

* refactor(ui): externalize UtxoTags component

* ui(send): show considered UTXOs before performing transaction (#807)

---------

Co-authored-by: apX13_ <[email protected]>
Co-authored-by: Thebora Kompanioni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants