Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): disable lock button while locking wallet #759

Merged
merged 1 commit into from
May 21, 2024

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented May 16, 2024

Locking the wallet can take some time (sometimes a few seconds, e.g. via Tor). This avoids additional requests being made if the button is clicked while a request is in-flight.

(It is not totally obvious in the screenshot, but the button is disabled)

@theborakompanioni theborakompanioni added the UI/UX Issue related to cosmetics, design, or user experience label May 16, 2024
@theborakompanioni theborakompanioni self-assigned this May 16, 2024
Copy link
Contributor

@amitx13 amitx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! There are no additional requests; everything is working fine.

@theborakompanioni theborakompanioni merged commit 1a620f3 into master May 21, 2024
3 checks passed
@theborakompanioni theborakompanioni deleted the fix/disable-lock-button-when-locking branch May 21, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants