-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui(orderbook): add delay hint to highlighted offer toggle #735
Conversation
fedfff0
to
4f4b73e
Compare
can you pull the view on toggle down to the green highlighted row? people would understand faster |
I am sorry, I do not understand what you mean exactly. Can you please explain this in more detail? |
sure, sorry.
is this possible? |
Ah, thanks for clarifying. Of course that would be possible. However, isn't it kind of unexpected to scroll down on click on a toggle? |
Notes from discussion:
|
4f4b73e
to
170b59d
Compare
Thought about this some more.
What feels like a good solution to point #3 is: 📸Offer absent (toggle disabled + subtitle hint)Offer presentOffer present, highlightedOffer present, pinned to topWhat do you think @editwentyone ? |
@theborakompanioni i'm fine with the changes :) you can merge |
Adds a small hint that it might take some time for an offer to appear in the local order book, e.g. when the maker has just been started recently. This hint will disappear if the current nickname is present in the offer list.
Edit: Screenshots outdated - see below 🙏
📸
Before
After