feat: add dedicated error page #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
requested review from
editwentyone
and removed request for
dergigi
dergigi
approved these changes
Jan 23, 2023
dergigi
approved these changes
Jan 23, 2023
|
Looks like this now:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, in case there was an error, a generic error page had been shown.
After this commit, a dedicated error page, including the navbar, the footer and with a link to create an issue on GitHub, will be displayed.
Whenever you browse the app, this page should never render in the first place, as all error are to be handled by the actual component. However, some errors slip through (e.g. with the date parsing bug in safari #584) and then, the user should be presented with a better view.
The page is really just the bare minimum. The error is unexpected and in most cases, cannot be resolved by the user without support.
In order for this to work properly, the dependency
react-router-domhas been upgraded fromv6.4.3tov6.6.1.How to test
In dev mode (when starting with
npm run dev:start), a special route with nameerror-exampleis present.Visit http://localhost:3000/error-example to view this page.
📸 Before
📸 After