Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install python3-venv in regtest environment #585

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Jan 3, 2023

Fixes #581

Quick workaround to make the regtest environment compatible with the current state of master (ea7a6e) again. This can be removed once the install script is fixed upstream.

Also, adapts the payjoin server port from 8080 to 8082 according to 2749da1 - included in JM v0.9.9.

Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tACK ✅

@dergigi dergigi merged commit d9b0415 into master Feb 1, 2023
@dergigi dergigi deleted the fix/regtest-python3-venv branch February 1, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtools Improvements in tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to run this locally and getting error when i run "npm run regtest:up"
2 participants