Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update react-router-dom from v6.3.0 to v6.4.1 #519

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Sep 26, 2022

Updates dependency react-router-dom from v6.3.0 to v6.4.1.

Originally wanted to leverage the new loader feature to separate data loading from view rendering.
This will be done in a follow-up PR as we often update context data which cannot be done in a satisfactory way yet (see remix-run/react-router#9324).

@theborakompanioni theborakompanioni added the dependencies Pull requests that update a dependency file label Sep 26, 2022
@theborakompanioni theborakompanioni self-assigned this Sep 26, 2022
@theborakompanioni theborakompanioni requested a review from a team September 26, 2022 15:30
@theborakompanioni theborakompanioni marked this pull request as ready for review September 26, 2022 15:30
Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general, but we should address the 404 error (unless it's something I'm doing wrong on my side).

src/components/App.tsx Show resolved Hide resolved
Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, Looks good to me ✅

@dergigi dergigi merged commit c79a969 into master Sep 29, 2022
@dergigi dergigi deleted the deps-router-update branch September 29, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants