Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: components from jsx to tsx #509

Merged
merged 8 commits into from
Sep 26, 2022
Merged

refactor: components from jsx to tsx #509

merged 8 commits into from
Sep 26, 2022

Conversation

theborakompanioni
Copy link
Collaborator

Small refactoring turning some components from Javascript to TypeScript.

  • JarSelectorModal
  • Alert
  • ActivityIndicators
  • App and App.test
  • setupTests.js to setupTests.ts

No functionality has been changed.

@theborakompanioni theborakompanioni added the refactoring Code refactoring without functional changes label Sep 21, 2022
@theborakompanioni theborakompanioni self-assigned this Sep 21, 2022
@theborakompanioni theborakompanioni marked this pull request as ready for review September 21, 2022 12:28
@theborakompanioni theborakompanioni requested a review from a team September 21, 2022 12:28
dergigi
dergigi approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tACK ✅

src/components/fb/CreateFidelityBond.jsx Show resolved Hide resolved
@dergigi dergigi merged commit d043353 into master Sep 26, 2022
@dergigi dergigi deleted the refactor-js-to-ts branch September 26, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dergigi dergigi dergigi approved these changes

Assignees

@theborakompanioni theborakompanioni

Labels
refactoring Code refactoring without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theborakompanioni @dergigi