feat: show active offers #461
Conversation
theborakompanioni
added
enhancement
theborakompanioni
force-pushed
the
show-offer
branch
2 times, most recently
from
0956a19 to
9725b61
Compare
|
This is great! Will test it later--I'm having issues building the regtest right now. 😅 Regarding the questions:
Honestly, I'd go for "Offer ID"--that's what it is in this context, right? I know this is the nickname on the IRC servers as well, but that's something the average user doesn't care about I guess. See also #413 where it's referred to as ID.
Good question! How about renaming the "show/hide balance" toggle to "show/hide sensitive data" and then also hiding the nick?
Without having tried it yet, what about showing the normal placeholder in the case where we can anticipate that an offer will be present in the |
| .offerContainer { | ||
| border: 1px solid var(--bs-gray-200); | ||
| border-radius: 0.3rem; | ||
| padding: 1.25rem; | ||
| margin-bottom: 1.5rem; | ||
| } | ||
|
|
||
| :root[data-theme='dark'] .offerContainer { | ||
| border-color: var(--bs-gray-700); | ||
| } | ||
|
|
||
| .offerContainer .offerTitle { | ||
| width: 100%; | ||
| font-size: 1.2rem; | ||
| color: var(--bs-body-color); | ||
| } | ||
|
|
||
| .offerContainer .offerLabel { | ||
| color: var(--bs-gray-600); | ||
| font-size: 0.8rem; | ||
| } | ||
|
|
||
| .offerContainer .offerContent { | ||
| font-size: 0.8rem; | ||
| word-break: break-all; | ||
| } |
There was a problem hiding this comment.
That's the same styles as the existing FB box right?
theborakompanioni
force-pushed
the
show-offer
branch
from
2508cdd to
dd59190
Compare
|
Found a small edge case, I think. When the string contains an
Might not be a big problem, because it's still an Here is how it looks if we wrap the whole string in a |
Nice one! Adding css class |
Resolves #399. Also partly addresses #413 (but will be additionally tackled in a separate PR).
Shows the current active offers on the Earn page.
Please review and merge #456 before this PR.
These changes need JM built from the current
master(at least including commit 6ec5c35c).Questions:
showBalanceis disabled?/sessionresponse arrives..