feat: improve wallet control in settings

[ghost]

Resolves #323. Lays some groundwork for #228.

Adds actions for locking the wallet and creating a new wallet to the settings. We're not at a single wallet flow yet but this lays some groundwork for it and makes features available through the settings screen, which were previously accessible only on the wallets screen.

Also updates the UI of the modal used to warn the user before locking a wallet where a service is running.

📸

[theborakompanioni]

Sorry for repeating myself, but I think TypeScript would be cool – especially for such small and new components.

The modal looks slick : D
Great work. Approved.

[ghost]

Sorry for repeating myself, but I think TypeScript would be cool – especially for such small and new components.

I refrained from using it here for such a light component with no real API and complex logic. Mostly because I feel like it adds a lot of complexity everywhere. But I won't die on that hill. I can update it if you feel like we should use it more consistently?

[theborakompanioni]

I refrained from using it here for such a light component with no real API and complex logic. Mostly because I feel like it adds a lot of complexity everywhere. But I won't die on that hill. I can update it if you feel like we should use it more consistently?

No, it's okay. 👍
I don't want to create any additional work.

I think IDE support improves a lot with TypeScript. Will do it myself once we are polishing things up, if it pays off at all.

[ghost]

I think IDE support improves a lot with TypeScript.

Good point! 👍

[editwentyone]

new proposal that I came up with right now:

instead of "create wallet" directly on settings page, we could remove that, and rename "switch wallet" to "manage wallets", there the user can directly lock, unlock and create stuff.

and in the future it makes more sense because there the user could also import and maybe export wallets. what do you think?

[ghost]

I feel like what we have implemented atm is good enough for now. It's a rather niche feature -- I wouldn't want to spend too much time on it right now. We can definitely keep the idea in the backlog for now, though. Feel free to create an issue for it. :)

[editwentyone]

thanks, you are right, I will open a new issue #337