ui: Settings screen according to figma

[theborakompanioni]

Adapt Settings screen according to Figma.

Differences:

• "Log out" is in section "Wallet" instead of "Settings"

Question:

• Should the "Create new wallet" button be removed? Personally, leaning towards "Yes". (related Make one wallet the standard #228)

📸 Before

📸 After

[editwentyone]

the Logout is for the whole app, not on wallet level. it should go over Wallet category please :)

maybe even "Log out from Jam"

[theborakompanioni]

maybe even "Log out from Jam"

Hmm.. I am not sure I know what this means.

Currently "logging out" is just forgetting the session key. What should happen, when someone "logs out"?

[editwentyone]

its should bring you to "login page" https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/?node-id=3994%3A73345

but I think we do not have that yet

[ghost]

the Logout is for the whole app, not on wallet level.

I think these are equivalent things at this time (as @theborakompanioni mentioned) right?

Edit: You are right, in the future when we have a "single wallet flow" and a central, wallet-independent login page, it should go there of course.

[ghost]

Is home still needed?

[theborakompanioni]

Thought about this myself. Opted for keeping it, as e.g. the navbar does not need to know what the actual route is (and using "/" hardcoded for this feels inconsistent). Is this reasonable?

[ghost]

No but I mean routes.home and routes.walletList are duplicates, right?

[editwentyone]

I think that "log out" from Wallet, because its now used differently, is misleading.

logout should be only used when the user logged in somewhere, if that's not the case, we need to rethink what's actually happening.

I would move logout back up again and hide it as long as we don't have login implemented. why would a user logout aka "lock" the wallet and not just close the window? what happens when we just close the window?

~

so we have:

• create wallet: creating new wallets, not possible while another wallet is still used and unlocked
• unlock wallet: wallet is inactive, needs password to be active
• open wallet: entering, using, wallet is active
• lock wallet: deactivate wallet, wallet is now inactive
• Logout wallet (misunderstanding): wallet stays active in the background, needs password to be opened/ entered again

[theborakompanioni]

I would move logout back up again and hide it as long as we don't have login implemented.

Removed it for now.

why would a user logout aka "lock" the wallet and not just close the window?

You are right, the (now removed) "Log out" action, by forgetting the auth token, would have been the same as closing the window.
However, I can relate to some uneasiness when closing a tab with an "unlocked" wallet. A dedicated button would "feel" a little better, albeit there is no difference in what actually happens.

what happens when we just close the window?

The auth token is removed (as sessionStorage cleared when the page session ends).

~

so we have:

* **create wallet**: creating new wallets, not possible while another wallet is still used and unlocked

* **unlock wallet**: wallet is _inactive_, **needs password** to be active

* **open wallet**: entering, using, wallet is _active_

* **lock wallet**: deactivate wallet, wallet is now _inactive_

* **Logout** wallet (misunderstanding): wallet stays active in the background, **needs password** to be opened/ entered again

Maybe something like "Leave wallet", "Exit wallet" or "Close wallet" (although the term "Closing" might be confused by "Locking")?

In any case, I have just removed it for now and will support anything that you think makes most sense from an UI/UX perspective.
Do you think these changes can be merged?

[ghost]

Removing seems like n acceptable solution for now. 👍 All the nuances are way to complicated, we really need to figure out a good concept for this.

---

A little padding for the buttons on mobile would be great.

[theborakompanioni]

A little padding for the buttons on mobile would be great.

Yeah, did not change that, as I supposed it was intentional. Any improvements are very welcome! Feel free to just push to this branch!

[ghost]

Yeah, did not change that

Good point! :D Will push an update.

[editwentyone]

hidden is ok for me, I sketched already something for the next call, and yeah: its confusing :P

[0xSaksham]

@theborakompanioni, I was taking inspiration for ConfirmModal use case and found out that this feature doesn't work here. If you want I can work on it?

[theborakompanioni]

@theborakompanioni, I was taking inspiration for ConfirmModal use case and found out that this feature doesn't work here. If you want I can work on it?

I am not quite sure what you are referring to.. can you elaborate?

[0xSaksham]

Confirm modal wants you to confirm that you really want to do this.

But there's no modal opening up here.

[theborakompanioni]

Sorry @0xSaksham, I still do not understand. What is it you want to work on or which change do you have in mind in the context of this issue?

[0xSaksham]

@theborakompanioni let's discuss this in tomorrow's meeting.

If there's no meeting, we'll discuss this in one-on-one call.