Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fidelity bonds in developer mode #221
feat: Fidelity bonds in developer mode #221
Changes from 15 commits
e99869c
cc74b4f
c7e8211
54cd533
a601f48
606d490
688178c
c33c567
f2bfc99
5d8131e
2d6831f
fdd3206
7b99317
81b1f98
4281778
9ff85f4
83595bf
03c64d0
6521da0
b7f4290
784ae27
9a4c48d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I don't think we need that extra step. It's already only in "advanced" mode (which is called developer mode in the app already). Once the user is here I'd say we can let them do their stuff. No need for the extra hurdle imo. What do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need two distinct modes. As a developer, I want to have access to the actual timelock address, which does not necessarily need to be exposed to a user ever. Do you have a preferred way to do this or do you have different mechanism in mind?
Having a dedicated view for local development seemed to be the easiest solution to me.
e.g. Creating Fidelity Bonds in the past – a user should never be able to do that.. in development it is very useful, though.