Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: allow absolute maker fee of zero #726

Closed
theborakompanioni opened this issue Mar 11, 2024 · 0 comments · Fixed by #727
Closed

bug: allow absolute maker fee of zero #726

theborakompanioni opened this issue Mar 11, 2024 · 0 comments · Fixed by #727
Labels
bug Something isn't working
Milestone
v0.3.5

Comments

@theborakompanioni
Copy link
Collaborator

Expected behavior

Absolute maker fees can be set to zero (0).
This was working in previous versions and breaks since v0.2.0.

Actual behavior

A value greater than zero has to be chosen.

Steps to reproduce the problem

  1. Go to the "Earn" tab
  2. Select absolute fee and insert 0 as value
  3. Try starting the maker and verify it is not accepted

Additional context

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.3.5
Development

Successfully merging a pull request may close this issue.

fix: allow absolute maker fee of zero joinmarket-webui/jam
1 participant
@theborakompanioni