Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How to change settings in joinmarket.cfg ? #136

Closed
Ulawun opened this issue Oct 17, 2024 · 7 comments
Closed

Question: How to change settings in joinmarket.cfg ? #136

Ulawun opened this issue Oct 17, 2024 · 7 comments
Labels
question Further information is requested

Comments

@Ulawun
Copy link

Ulawun commented Oct 17, 2024

Hello :-)

The ghcr.io/joinmarket-webui/jam-standalone container is running and
I can access it via firefox :-)
Now I want to be maker and set my fees to zero.

I found out, that I have to add/change the joinmarket.cfg file
with the line "ordertype = absoffer".
Is this correct ?

I created a joinmarket.cfg file on the server
with the content: "ordertype = absoffer".
Then I started docker with this parameter
"--env RESTORE_DEFAULT_CONFIG="/path/to/my/folder/joinmarket.cfg".
When I then start docker and click "earn",
it is shown, that my fee is greater than zero !
What do I have to do ?

Any ideas pls ?
Thx :-)

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Oct 17, 2024

Hello :-)

The ghcr.io/joinmarket-webui/jam-standalone container is running and I can access it via firefox :-)
Great! :-)

Now I want to be maker and set my fees to zero.
💯 🙏

I found out, that I have to add/change the joinmarket.cfg file with the line "ordertype = absoffer". Is this correct ?

If you are using Jam, you can select that option on the Earn page! See the "Offer options" dropdown!
https://jamdocs.org/interface/03-earn/#offer-options

I created a joinmarket.cfg file on the server with the content: "ordertype = absoffer". Then I started docker with this parameter "--env RESTORE_DEFAULT_CONFIG="/path/to/my/folder/joinmarket.cfg". When I then start docker and click "earn", it is shown, that my fee is greater than zero ! What do I have to do ?

See above. I think this is easier for what you want to achieve.

RESTORE_DEFAULT_CONFIG is a boolean flag and must be disabled, if you want to bring a completely custom config to the container. However, I think this not necessary in this case.

Any ideas pls ? Thx :-)

Let us know, if it worked. 🙏

@theborakompanioni theborakompanioni added the question Further information is requested label Oct 17, 2024
@Ulawun
Copy link
Author

Ulawun commented Oct 18, 2024

Thanks a lot theborakompanioni :-)

I first tried the "Offer options" dropdown
to set my maker fees to zero,
see attached picture "1":
1

When I do this,
the earn page doesn't show any offers,
see attached picture "2":
2

For me it looks like,
that joinmarket doesn't accept the maker fee to be zero !
Also on the "orderbook" page
there is no maker offer with zero fee !

When I set my maker fees to 1 sats,
my maker offer is working !

I would like to offer a zero fee mix,
because then I would have better chances to be mixed ...

Do you know a way to offer a maker fee of zero ?

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Oct 21, 2024

Do you know a way to offer a maker fee of zero ?

Yes, I think this has been fixed and works in the current version (v0.3.0). Update Jam and creating an "absolute offer" with 0 sats should be possible.

Edit: Docker image ghcr.io/joinmarket-webui/jam-standalone:v0.3.0-clientserver-v0.9.11.

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Oct 21, 2024

@Ulawun By the way, thanks for pointing this out. A relative offer with 0% leads to a crash of the backend, so this should be prevented. 🙏

@Ulawun
Copy link
Author

Ulawun commented Oct 28, 2024

Thanks a lot theborakompanioni :-)
I will upgrade to v0.3.0, when my newest issue is fixed: #137
Thx :-)

@theborakompanioni
Copy link
Collaborator

Thanks a lot theborakompanioni :-) I will upgrade to v0.3.0, when my newest issue is fixed: #137 Thx :-)

Perfect. Can this issue be closed?

@Ulawun
Copy link
Author

Ulawun commented Oct 31, 2024

Thanks again :-)
Yes, can be closed.
I will try to close threads in the future ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants