Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for missing jm working directory if it is not mapped to the host system.
The log feature introduced a regression bug, when the logs moved from directory
$JM_WORK_DIR/logs
to/var/log/jam
.Since then, it was not ensured that the directory actually exists.
In most setups this is no problem, as the directory will most probably always be mapped to the host system via
--volume jmdatadir:/root/.joinmarket
, but in some situation, e.g. just starting the image once, this might lead to an error when the config file is copied:cp: cannot create regular file '/root/.joinmarket/joinmarket.cfg': No such file or directory
.The added line
mkdir --parents "${DATADIR}/"
now creates the directory in case it is missing.Small additional change: In order to prevent supervisord from searching for its configuration file in multiple locations and printing a warning message to stdout, the path to the config file is passed as a parameter.