Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run tor daemon with distinct user #61

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Aug 29, 2022

Closes #60.

Before this PR the tor daemon ran as user root.
After this PR a distinct tor user is created and used to start the tor daemon.

Image of this branch is published and can be tested by pulling
docker pull ghcr.io/joinmarket-webui/jam-dev-standalone:tor-user

@dergigi
Copy link
Contributor

dergigi commented Sep 9, 2022

I tried to use the tor-user image by changing one line in the Dockerfile:

diff --git a/docker/regtest/dockerfile-deps/joinmarket/webui-standalone/Dockerfile b/docker/regtest/dockerfile-deps/joinmarket/webui-standalone/Dockerfile
index 6a8b677..9e8da0f 100644
--- a/docker/regtest/dockerfile-deps/joinmarket/webui-standalone/Dockerfile
+++ b/docker/regtest/dockerfile-deps/joinmarket/webui-standalone/Dockerfile
@@ -1,4 +1,4 @@
-FROM ghcr.io/joinmarket-webui/joinmarket-webui-dev-standalone:master
+FROM ghcr.io/joinmarket-webui/joinmarket-webui-dev-standalone:tor-user

Unfortunately, it failed with the following error on npm run regtest:rebuild:

Sending build context to Docker daemon  18.94kB
Step 1/3 : FROM ghcr.io/joinmarket-webui/joinmarket-webui-dev-standalone:tor-user
manifest unknown
ERROR: Service 'joinmarket2' failed to build : Build failed

I tried again after running a regtest:clear just to make sure. Same result.

@theborakompanioni
Copy link
Collaborator Author

I tried again after running a regtest:clear just to make sure. Same result.

The image is jam-dev-standalone:tor-user not joinmarket-webui-dev-standalone:tor-user 😉

@dergigi
Copy link
Contributor

dergigi commented Sep 9, 2022

Ah, damn 🤦 - give me another minute.

Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, problem was on my side, obviously.

tACK ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tor daemon with distinct user
2 participants