dev: add tor from repo to standalone #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2022
ghost
reviewed
Jul 20, 2022
ghost
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Tested this as described in joinmarket-webui/jam#396.
Both a scheduler round on instance A (the dev regtest build) with instance B (the standalone regtest build) as a maker and a single coinjoin on instance B with instance A as a maker worked.
I don't know anything about configuring Tor, though. So I can only acknowledge that everything worked on my machine (in regtest).
Thank you @dnlggr 👍 |
|
Same as dnlggr, I don't know much about this. Changeset looks good to me, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43.
This PR adds Tor to the
standaloneimage.Before this PR, an external container has been necessary to connect to IRC or to the directory nodes.
After this PR is applied, the image lives up to its name and is truly "standalone", meaning: No external dependencies. A Tor daemon will be started at the startup of the container.
The changes in this PR are up to debate and every input or suggestion is highly appreciated.
How to test?
This PR can be tested by following the instructions in joinmarket-webui/#396 . A build of this branch has been made available as docker image, which is extended by the secondary container in the regtest setup.
Addendum
Previous attempts included installing Tor from source via flag
--with-local-torof joinmarket'sinstall.shscript.This has been working great locally, but led to longer build times on GitHub's environment (from ~40min to up to ~2h(!)) and subsequently failing at the unit tests for Tor ([1], [2], [3]). Installing it from an official repository (via
apt-get) is a compromise between ease of use and robustness. Before, it was relied upon an external container, where the sources where also "unknown", or, as e.g. in Umbrels case, totally outside of the users control. It is always possible for a user to switch to another instance by adapting and passing configuration variables.