Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nginx): increase upstreams shared memory size #124

Merged
merged 1 commit into from
May 7, 2024

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented May 6, 2024

Resolves #123.

Increases the shared memory zone size from 64k to 256k.
This should fix problems reported by users on umbrelOS 1.x.

@theborakompanioni theborakompanioni added the bug Something isn't working label May 6, 2024
@theborakompanioni theborakompanioni self-assigned this May 6, 2024
@theborakompanioni theborakompanioni merged commit 681cb89 into master May 7, 2024
@theborakompanioni theborakompanioni deleted the fix/nginx-zone-size branch May 7, 2024 12:58
@nmfretz
Copy link

nmfretz commented May 14, 2024

Thanks a ton for this @theborakompanioni! Would you and the team consider releasing an official Docker image with this change so that Raspberry Pi 5 users can run Jam?

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented May 14, 2024

Thanks a ton for this @theborakompanioni! Would you and the team consider releasing an official Docker image with this change so that Raspberry Pi 5 users can run Jam?

Yes, of course! I will tag it with v0.2.0-clientserver-v0.9.11-YYYYMMDD-patch (e.g. v0.2.0-clientserver-v0.9.11-20240514-patch) after some more testing (there are some other updates included as well) and will let you know when it is finished.

@nmfretz
Copy link

nmfretz commented May 14, 2024

Thanks, super appreciated!

@theborakompanioni
Copy link
Collaborator Author

Thanks, super appreciated!

Currently the automated docker builds are failing (due to network timeouts). Don't know if it is still related to the latest GitHub Actions incident. Will ping you as soon as it works again.

@theborakompanioni
Copy link
Collaborator Author

Thanks a ton for this @theborakompanioni! Would you and the team consider releasing an official Docker image with this change so that Raspberry Pi 5 users can run Jam?

Hey @nmfretz! Finally went through. Guess we need some adaptions to the build, as this was an unpleasant experience.
See the docker image here: https://github.com/joinmarket-webui/jam-docker/pkgs/container/jam-dev-standalone/219324914?tag=v0.2.0-clientserver-v0.9.11-patch-20240521

Prefixed with "jam-dev-standalone":

ghcr.io/joinmarket-webui/jam-dev-standalone:v0.2.0-clientserver-v0.9.11-patch-20240521
sha256:6716161d0a5d4514d6744bf8351c7490f3446a7ba52eb736e10ec62ffb0dc491

Do you need any more information? Are you updating the app in umbrel yourself, or should I create a PR? 🙏

@nmfretz
Copy link

nmfretz commented May 22, 2024

amazing, thanks @theborakompanioni!

Do you need any more information? Are you updating the app in umbrel yourself, or should I create a PR? 🙏

Nothing else needed. I'll update Jam on the Umbrel app store now. Thanks again for looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jam 0.2.0 nginx issue on Raspberry Pi 5 (umbrelOS)
3 participants