Expensive for creating parser instance in execute() method.

CSV parser is not thread safe Closes #4
johtani · Sep 7, 2019 · e17ca1c · e17ca1c
1 parent 611d9c4
commit e17ca1c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/main/java/info/johtani/elasticsearch/plugin/ingest/csv/CsvProcessor.java b/src/main/java/info/johtani/elasticsearch/plugin/ingest/csv/CsvProcessor.java
@@ -55,7 +55,10 @@ public IngestDocument execute(IngestDocument ingestDocument) throws Exception {
         String content = ingestDocument.getFieldValue(field, String.class);
 
         if (Strings.hasLength(content)) {
-             String[] values = parser.parseLine(content);
+            String[] values;
+            synchronized (parser) {
+                values = parser.parseLine(content);
+            }
             if (values.length != this.columns.size()) {
                 // TODO should be error?
                 throw new IllegalArgumentException("field[" + this.field + "] size ["