Use syscall.Exec instead of cmd.Run in non-windows environment #77

Songmu · 2019-06-17T06:40:56Z

Using syscall.Exec makes the process tree simpler and is useful when you want the child process to handle the signal.

For example, the direnv program internally uses syscall.Exec.

https://github.com/direnv/direnv/blob/5b8f7d0ade4248e04899015e8628408b6f4becf3/cmd_exec.go#L67

How about it?

Using exec is better in this case as it makes the process tree simpler, and allows the child's signals to be handled by the caller. In addition the `Exec` function has been removed as it's not really great as a library function. Users should manually call the `Load` function and run `exec.Command` or `syscall.Exec` appropriately. In the future we probably want to handle signals for Windows anyway. This is based on joho/godotenv#77 and also addresses the following PRs in upstream: - joho/godotenv#119

Use syscall.Exec instead of cmd.Run in non-windows environment

b7402b1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use syscall.Exec instead of cmd.Run in non-windows environment #77

Use syscall.Exec instead of cmd.Run in non-windows environment #77

Songmu commented Jun 17, 2019

Use syscall.Exec instead of cmd.Run in non-windows environment #77

Are you sure you want to change the base?

Use syscall.Exec instead of cmd.Run in non-windows environment #77

Conversation

Songmu commented Jun 17, 2019