Skip to content

Commit

Permalink
Merge pull request #4 from GoIncremental/4-windows-line-returns
Browse files Browse the repository at this point in the history
Tests failing on Windows
  • Loading branch information
joho committed Jul 14, 2014
2 parents 3c13a80 + bdacd70 commit 68b1921
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
13 changes: 10 additions & 3 deletions godotenv.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ and all the env vars declared in .env will be avaiable through os.Getenv("SOME_E
package godotenv

import (
"bufio"
"errors"
"io/ioutil"
"os"
"strings"
)
Expand Down Expand Up @@ -87,14 +87,21 @@ func loadFile(filename string) (err error) {
}

func readFile(filename string) (envMap map[string]string, err error) {
content, err := ioutil.ReadFile(filename)
file, err := os.Open(filename)

// content, err := ioutil.ReadFile(filename)
if err != nil {
return
}
defer file.Close()

envMap = make(map[string]string)

lines := strings.Split(string(content), "\n")
var lines []string
scanner := bufio.NewScanner(file)
for scanner.Scan() {
lines = append(lines, scanner.Text())
}

for _, fullLine := range lines {
if !isIgnoredLine(fullLine) {
Expand Down
3 changes: 2 additions & 1 deletion godotenv_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ func loadEnvAndCompareValues(t *testing.T, envFileName string, expectedValues ma

func TestLoadWithNoArgsLoadsDotEnv(t *testing.T) {
err := Load()
if err.Error() != "open .env: no such file or directory" {
pathError := err.(*os.PathError)
if pathError == nil || pathError.Op != "open" || pathError.Path != ".env"{
t.Errorf("Didn't try and open .env by default")
}
}
Expand Down

0 comments on commit 68b1921

Please sign in to comment.