Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use convention mapping for classifier on old gradle #502

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Use convention mapping for classifier on old gradle #502

merged 1 commit into from
Sep 7, 2019

Conversation

grossws
Copy link
Contributor

@grossws grossws commented Jul 3, 2019

Fixes #463

@johnrengelman johnrengelman merged commit d5c662a into GradleUp:master Sep 7, 2019
@cvielma
Copy link

cvielma commented Sep 16, 2019

I'm not sure this fixes #463 because the classifier will always be "-all". Is there a way to get rid of the classifier?

@skmedix
Copy link

skmedix commented Sep 16, 2019

https://imperceptiblethoughts.com/shadow/configuration/#configuring-output-name

@cvielma
Copy link

cvielma commented Sep 16, 2019

yeah, what I was missing was that classifier is deprecated in gradle: https://docs.gradle.org/current/dsl/org.gradle.api.tasks.bundling.Jar.html#org.gradle.api.tasks.bundling.Jar:classifier but I guess it goes beyond the scope of this change.

@johnrengelman johnrengelman added this to the 5.2.0 milestone Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnrengelman johnrengelman johnrengelman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Removing the default classifier with the archiveClassifier property
4 participants
@grossws @cvielma @skmedix @johnrengelman