Use convention mapping for classifier on old gradle (#502)

Fixes #463
GradleUp · Sep 7, 2019 · d5c662a · d5c662a
1 parent 2d2bd66
commit d5c662a
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.groovy b/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.groovy
@@ -41,13 +41,14 @@ class ShadowJavaPlugin implements Plugin<Project> {
         ShadowJar shadow = project.tasks.create(SHADOW_JAR_TASK_NAME, ShadowJar)
         shadow.group = SHADOW_GROUP
         shadow.description = 'Create a combined JAR of project and runtime dependencies'
-        shadow.conventionMapping.with {
-            map('classifier') {
-                'all'
-            }
-        }
         if (GradleVersion.current() >= GradleVersion.version("5.1")) {
             shadow.archiveClassifier.set("all")
+        } else {
+            shadow.conventionMapping.with {
+                map('classifier') {
+                    'all'
+                }
+            }
         }
         shadow.manifest.inheritFrom project.tasks.jar.manifest
         shadow.doFirst {