New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an indeterminate state to canPush #11

Merged

johnpatrickmorgan merged 1 commit into main from bugfix/prevent-can-push-assertions-for-child-coordinators

Jan 7, 2022

Owner

johnpatrickmorgan commented Jan 6, 2022 •

edited

Loading

This PR:

Adds an indeterminate state to canPush, to allow for cases where a parent coordinator might be responsible for the NavigationView. It makes the canPush assertion a little less useful, but avoids wrongfully asserting when the routes array is managed by a child coordinator that is being pushed onto a parent's stack (Route.root should probably use .push instead of .sheet #10).


          Adds an indeterminate state to canPush

f8f5936

johnpatrickmorgan mentioned this pull request

Route.root should probably use .push instead of .sheet #10

Closed

johnpatrickmorgan merged commit c50710a into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet