Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] rework SuperPixel and SuperPixelImage with Array interface #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnychen94
Copy link
Owner

The reasoning behind this rework:

  • a superpixel is a collection of pixels (values and indices)
    • values is an array of colorants
    • indices can be tuple of ranges, CartesianIndices, or even a tile
  • lazily do getindex(::SuperPixel, inds...) for both simplicity and performance.

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #6 (bed6a7e) into master (a663fef) will increase coverage by 6.32%.
The diff coverage is 82.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   64.44%   70.76%   +6.32%     
==========================================
  Files           3        4       +1     
  Lines          45       65      +20     
==========================================
+ Hits           29       46      +17     
- Misses         16       19       +3     
Impacted Files Coverage Δ
src/SuperPixels.jl 100.00% <ø> (ø)
src/types.jl 46.15% <46.15%> (-19.07%) ⬇️
src/synthesize.jl 95.12% <94.87%> (-4.88%) ⬇️
src/algorithms.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a663fef...bed6a7e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant