Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated ifloor(x) with floor(Int, x) #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpfairbanks
Copy link

ifloor is deprecated in 0.4. does this need to be wrapped in a version check to support both 0.3 and 0.4?

@johnmyleswhite
Copy link
Owner

Yeah, we can't merge this unless you're prepared to drop 0.3 support.

Otherwise looks good!

@jpfairbanks
Copy link
Author

is it better to make a compatible definition of ifloor when using the new version

if VERSION >= v"0.4"
    ifloor(x) = floor(Int, x)
end

and just keep using the old api? In this case it seems not to matter but in general is that a bad idea for the long run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants