Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to swift3.0 #42

Merged
merged 2 commits into from
Sep 20, 2016
Merged

Update to swift3.0 #42

merged 2 commits into from
Sep 20, 2016

Conversation

iceman201
Copy link
Contributor

Notes: there is one comments which Im not too sure how to re-write, please check out around line 143-144

johnlui and others added 2 commits June 28, 2016 02:13
@johnlui
Merge pull request johnlui#34 from johnlui/swift3
cfb0418 
修正 gif 无法正常显示的问题
@iceman201
Update to swift3.0
9e8a495 
Notes: there is one comments which Im not too sure how to re-write, please check out around *line 143-144*
iceman201
iceman201 commented Sep 20, 2016
View reviewed changes
Copy link
Contributor Author

@iceman201 iceman201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not too sure how to re-write that part

SwiftNotice.swift
timer = dispatch_source_create(DISPATCH_SOURCE_TYPE_TIMER, 0, 0, dispatch_get_main_queue())
dispatch_source_set_timer(timer, DISPATCH_TIME_NOW, UInt64(timeInterval) * NSEC_PER_MSEC, 0)
dispatch_source_set_event_handler(timer, { () -> Void in
(timer as! DispatchSource).setTimer(start: dispatch_time_t(DISPATCH_TIME_NOW), interval: UInt64(timeInterval) * NSEC_PER_MSEC, leeway: 0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About here

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, I already has a fix.

@johnlui
Copy link
Owner

johnlui commented Sep 20, 2016

Thanks for your pr, and I will do the rest work for you.

@johnlui johnlui changed the base branch from master to swift3 September 20, 2016 13:01
@johnlui johnlui merged commit 8b9f644 into johnlui:swift3 Sep 20, 2016
ChengLuffy added a commit to ChengLuffy/SwiftNotice that referenced this pull request May 13, 2020
@ChengLuffy
Squashed commit of the following:
9223d06 
commit 75a4e69
Author: 成璐飞 <[email protected]>
Date:   Wed May 13 15:42:15 2020 +0800

    update for swift 5

commit 51d8e46
Author: JohnLui <[email protected]>
Date:   Thu Jan 3 00:35:06 2019 +0800

    iOS 8 bug fix

commit 38516c1
Author: JohnLui <[email protected]>
Date:   Tue Apr 10 11:37:17 2018 +0800

    compatible to Xcode 9.3

commit a46f3d0
Author: JohnLui <[email protected]>
Date:   Thu Nov 16 18:47:52 2017 +0800

    modify README

commit 0bce314
Author: JohnLui <[email protected]>
Date:   Thu Nov 16 18:42:07 2017 +0800

    support iPhone X

commit 5d4d802
Merge: a335414 1ff2c87
Author: John Lui <[email protected]>
Date:   Thu Oct 26 12:28:56 2017 +0800

    Merge pull request johnlui#51 from nsuxin/Swift4

    Support for Swift4

commit 1ff2c87
Author: Xin <[email protected]>
Date:   Thu Oct 26 12:15:51 2017 +0800

    Support for Swift4

commit a335414
Merge: 2888db9 7c43616
Author: John Lui <[email protected]>
Date:   Fri Jun 2 12:02:19 2017 +0800

    Merge pull request johnlui#50 from zzjzz9266a/swift3

    adjust the size of label if text is too long

commit 7c43616
Author: 张智杰 <[email protected]>
Date:   Fri Jun 2 11:54:48 2017 +0800

    adjust the size of label if text is too long

commit 2888db9
Merge: 8e0d503 e5e5d87
Author: John Lui <[email protected]>
Date:   Thu Apr 6 14:42:58 2017 +0800

    Merge pull request johnlui#47 from zzjzz9266a/swift3

    add new api for closing each single notice

commit e5e5d87
Author: 张智杰 <[email protected]>
Date:   Wed Apr 5 21:20:11 2017 +0800

    add new api for closing each single notice

commit 8e0d503
Merge: 0d7fa09 be09a0d
Author: John Lui <[email protected]>
Date:   Fri Nov 25 10:15:04 2016 +0800

    Merge pull request johnlui#43 from shiweifu/swift3

    简单增加动画效果

commit be09a0d
Author: shiweifu <[email protected]>
Date:   Thu Nov 24 18:46:08 2016 +0800

    简单增加动画效果

commit 0d7fa09
Author: JohnLui <[email protected]>
Date:   Tue Sep 27 16:15:40 2016 +0800

    fix iOS 8

commit ec45e4b
Author: JohnLui <[email protected]>
Date:   Wed Sep 21 21:39:56 2016 +0800

    modify README

commit 2b307a3
Author: JohnLui <[email protected]>
Date:   Wed Sep 21 21:37:44 2016 +0800

    everything is done

commit e08fc92
Author: JohnLui <[email protected]>
Date:   Tue Sep 20 22:41:37 2016 +0800

    migrat to Swift3 and iOS 10: the old orientation problem has been fixed

commit 8b9f644
Merge: 7a6fb56 9e8a495
Author: John Lui <[email protected]>
Date:   Tue Sep 20 21:02:07 2016 +0800

    Merge pull request johnlui#42 from iceman201/patch-1

    Update to swift3.0

commit 9e8a495
Author: Liguo Jiao <[email protected]>
Date:   Tue Sep 20 23:47:28 2016 +1200

    Update to swift3.0

    Notes: there is one comments which Im not too sure how to re-write, please check out around *line 143-144*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnlui johnlui johnlui left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iceman201 @johnlui