build: move e2e command to nx (#10)

.github/workflows/ci.yml

@@ -44,5 +44,7 @@ jobs:
             --configuration=ci
       - name: End to End Tests
         run: |
-          npx playwright install --with-deps
-          npm run e2e -- --browser=all
+          npx nx affected \
+            --base="${{ env.NX_BASE }}" \
+            --head="${{ env.NX_HEAD }}" \
+            --targets=e2e

.github/workflows/release.yml

@@ -12,7 +12,7 @@ jobs:
     name: Release Please
     runs-on: ubuntu-latest
     steps:
-      - uses: google-github-actions/release-please-action@v2
+      - uses: google-github-actions/release-please-action@v3.1.2
         id: release
         with:
           release-type: node
@@ -35,25 +35,25 @@ jobs:
             ]
       - name: Checkout
         uses: actions/checkout@v3
-        if: steps.release.outputs.releases_created
+        if: steps.release.outputs.release_created
       - name: Setup node
         uses: actions/setup-node@v3
         with:
           node-version: ${{ env.node_version }}
           registry-url: 'https://registry.npmjs.org'
-        if: steps.release.outputs.releases_created
+        if: steps.release.outputs.release_created
       - name: Cache node_modules
         id: cache-node-modules
         uses: actions/cache@v3
         with:
           path: node_modules
           key: ${{ runner.os }}-node-${{ env.node_version }}-${{ hashFiles('**/package-lock.json') }}
-        if: steps.release.outputs.releases_created
+        if: steps.release.outputs.release_created
       - name: Install
         run: npm ci
-        if: steps.release.outputs.releases_created && steps.cache-node-modules.outputs.cache-hit != 'true'
+        if: steps.release.outputs.release_created && steps.cache-node-modules.outputs.cache-hit != 'true'
       - name: Publish to NPM
-        if: steps.release.outputs.releases_created
+        if: steps.release.outputs.release_created
         env:
           NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
         run: |

.husky/pre-commit

@@ -6,6 +6,4 @@ set -ex
 npx pretty-quick --staged
 npx nx workspace-lint
 npx nx format:check
-npx nx affected --targets=lint,build,test --configuration=ci
-npx playwright install --with-deps
-npm run e2e -- --browser=all
+npx nx affected --targets=lint,build,test,e2e --configuration=ci

apps/e2e/project.json

@@ -83,6 +83,22 @@
       "options": {
         "lintFilePatterns": ["apps/e2e/**/*.ts", "apps/e2e/**/*.html"]
       }
+    },
+    "e2e": {
+      "dependsOn": [
+        { "target": "build", "projects": "dependencies" },
+        { "target": "build", "projects": "self" }
+      ],
+      "executor": "nx:run-commands",
+      "outputs": [],
+      "options": {
+        "commands": [
+          "npx playwright install --with-deps",
+          "npx playwright test -c apps/e2e/playwright.config.ts --browser=all"
+        ],
+        "parallel": false
+      }
     }
-  }
+  },
+  "implicitDependencies": ["ng-keyboard-sort"]
 }

package.json

@@ -9,7 +9,7 @@
     "test": "nx test ng-keyboard-sort --browsers=ChromeHeadless --code-coverage --watch=false",
     "test:e2e": "nx test e2e --browsers=ChromeHeadless --code-coverage --watch=false",
     "test:all": "nx affected:test --all --browsers=ChromeHeadless --code-coverage --watch=false",
-    "e2e": "playwright test -c apps/e2e/playwright.config.ts",
+    "e2e": "nx run-many --target=e2e --all",
     "lint": "nx run-many --target=lint --all --parallel",
     "commit": "cz",
     "prepare": "husky install"