test: create test objects in the stack instead of the heap

PR-URL: nodejs/node-addon-api#371 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
johnfrench3 · Oct 22, 2018 · f3fb1da · f3fb1da
1 parent fa5e345
commit f3fb1da
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/test/basic_types/boolean.cc b/test/basic_types/boolean.cc
@@ -12,8 +12,8 @@ Value CreateEmptyBoolean(const CallbackInfo& info) {
 }
 
 Value CreateBooleanFromExistingValue(const CallbackInfo& info) {
-  Boolean* boolean =  new Boolean(info.Env(), info[0].As<Boolean>());
-  return Boolean::New(info.Env(), boolean->Value());
+  Boolean boolean(info.Env(), info[0].As<Boolean>());
+  return Boolean::New(info.Env(), boolean.Value());
 }
 
 Value CreateBooleanFromPrimitive(const CallbackInfo& info) {

diff --git a/test/basic_types/number.cc b/test/basic_types/number.cc
@@ -67,8 +67,8 @@ Value OperatorDouble(const CallbackInfo& info) {
 }
 
 Value CreateEmptyNumber(const CallbackInfo& info) {
-  Number* number = new Number();
-  return Boolean::New(info.Env(), number->IsEmpty());
+  Number number;
+  return Boolean::New(info.Env(), number.IsEmpty());
 }
 
 Value CreateNumberFromExistingValue(const CallbackInfo& info) {