-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken SSR support since >2.0.1 #1
Comments
Hey there - sorry you're having trouble with this. Honestly I don't use SSR for my projects so I was never sure of SSR support for this component. I made a few changes around 2.0 but nothing to my knowledge that would make SSR support worse. Are you using nuxt.js for your SSR project? Have you tried whitelisting this component in some way during the initialization? Can you provide any more detail of how you're installing this component and your SSR configuration - I'm sorta ignorant on SSR usage so the more detail the better. Thanks. |
I don't think it's actually related to the SSR usage.. it happened when changes were made to the build. I looked at the min'd source, and noticed that there are checks built into 2.0.1 to check if it's a browser or on the server.. and starting in 2.1.0 that no longer exists. Something changed in this commit: |
Hey - yea idk this is a bit strange. Really only one dependency was updated in that commit - Although - one thing I noticed that I took out because I didn't see it being used was the |
That might be the fix, but now I'm getting other compile-time errors regarding plugins in your .babelrc. My project isn't using Babel 7.. I'm still on 6. due to a few outdated 3rd party libraries. Here's what it reports:
I might have to stay at version 2.0.1 of your library until I can get everything in my project upgraded. |
Hmm darn, I thought we were close! Although yea Babel 6 was released a while ago and may be the main issue here - it's hard to say. Well, when you update to Babel 7 then maybe you can let us know if it starts working for you? I'll be standing by to hear how it goes. Thanks. |
There are limitations in my project that won't let me upgrade for quite a
while.. But I'll let you know as soon as I can. Thanks a lot for the help
either way.
…On Tue., May 7, 2019, 3:52 p.m. John Datserakis, ***@***.***> wrote:
Hmm darn, I thought we were close! Although yea Babel 6 was released a
while ago and may be the main issue here - it's hard to say.
Well, when you update to Babel 7 then maybe you can let us know if it
starts working for you? I'll be standing by to hear how it goes. Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWU3SKOSN7VECVHPK5YD3PUHTZFANCNFSM4HG67PKA>
.
|
The text was updated successfully, but these errors were encountered: