Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _load_textdomain_just_in_time error. #940

Merged
merged 5 commits into from
Feb 2, 2025

Conversation

kagg-design
Copy link
Contributor

@kagg-design kagg-design commented Dec 22, 2024

Description

Since WP 6.7.0, an annoying message has been displayed in the QM console: "Function _load_textdomain_just_in_time was called incorrectly...".

The proper fix requires much work, such as moving all __() calls after the after_setup_theme event. This PR proposes a temporary fix for not outputting noise to QM users.

This PR may fix #919.

@johnbillion johnbillion added this to the 3.17.1 milestone Feb 2, 2025
Copy link
Owner

@johnbillion johnbillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@johnbillion johnbillion merged commit 2ade1db into johnbillion:develop Feb 2, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_load_textdomain_just_in_time was called incorrectly
2 participants