Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested ordered list option #42

Merged

Conversation

bjtho08
Copy link
Contributor

@bjtho08 bjtho08 commented Apr 22, 2024

This PR fulfills the feature requested in #41

@johansatge
Copy link
Owner

Hi

Thanks a lot for this contribution, looks like a great new option 🙏

We might need to add new unit tests; let me know if you want to do it yourself in this PR; otherwise I can also merge it and add a few myself before releasing a new version of the plugin.

Thanks!

@bjtho08
Copy link
Contributor Author

bjtho08 commented Apr 23, 2024

I actually have less than 30 minutes of experience with coding in js, so I might not be the right person to write new unit tests 🤣

This was just an experiment to see if I could do it myself by looking at how you had done the rest and taking advantage of AI auto-complete in VS Code 😉

But if you can specify what tests need to be added, I'm willing to give it a go myself. But, if you think it has to be done soon™️, then maybe it's better that you do it yourself 😄

@johansatge johansatge merged commit 3c91704 into johansatge:main May 19, 2024
@johansatge
Copy link
Owner

johansatge commented May 19, 2024

Thanks! Merged and updated a bit as I just discovered you can always put 1. as prefix (instead of the real number) to generate ordered lists, which makes the code simpler

Test looks like this: https://github.com/johansatge/obsidian-automatic-table-of-contents/pull/45/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants