-
-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: display project dropdown when typing "+" #3591
Feat: display project dropdown when typing "+" #3591
Conversation
Update on the failed test. The time in the test is 2024-10-12T13:37. When I ran the test locally, the local time was way after 13:37. So the custom date parser add one more day according to this. The parsed time becomes 2024-10-13T13:37 and the test failed. This makes sense: When the start time is behind the current time, e.g.: 13:37 vs 14:37, this 13:37 will be set to the next day. However, the logic Hope that makes sense 🤯 This test didn't fail on Github and earlier PR didn't catch this because the test time was before 13:37. |
Hi! Looks good, I've got a few tiny issues:
|
Searching for projects that starts with the typed letter is the default in
Have another field in the input that shows a task's metadata like scheduled time, project it belongs to, and assigned tags. These info are rendered as clickable buttons. User can click on the buttons to change the options, or delete it. Short syntax should best be reserved for quickly adding info. A good implementation is in Todoist. |
You beat me to it with the mentionFilter function ;) |
Thank you very much for this @bytrangle ! I think this is a great addition. I also agree that having buttons below like other todo apps do it, is something we should add as well. |
Thanks for mentioning the problems @stavby !! I added some code to take the settings into consideration. |
Description
When a user adds a task and types "+", it will display a dropdown list of currently unarchived projects.
Caveat: These changes caused the test should parse scheduled date using local time zone when unspecified to fail. I've temporarily commented out the test and will investigate it further.
Issues Resolved
Partially solves #3544
Check List