-
-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add setting to change tracking interval #2355 #3460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there Minnowo! 👋
Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖
We will try to review it soon!
Thank you very much! This looks very clean and I am quite happy. Two thoughts:
|
Something like TestBed.configureTestingModule({
providers: [provideMockStore({ initialState: {} })],
}); in |
I have also added the change you suggested for that test case. Running tests using Chromium seems to pass now on my machine. |
Thank you very much! This is a great addition! I'll try to figure something out for the timers once I have more time on my hands! |
Why is the max limited to 100000? I would like to limit writes to every 5 minutes as I don't see any need for it to write more frequently than that. |
It was an arbitrary number I had picked that seemed large enough at the time. I didn't really think much of it. Here is the line if you're interested in changing it:
|
Thank you |
Description
Added a setting
Time tracking interval
under theTime Tracking
category which lets the user change the tracking interval.I've put the title here as WIP since I am a new contributor, I have never used Angular, and have very limited experience with Typescript. So feedback is appreciated.
I've got some more testing but I think most of the functionality is there. Changing the setting properly updates the interval, and the value is persisted across page loads.
I still need to setup Electron and I'm not sure what to do about the other i18n files.
Issues Resolved
This is a bit of a simple fix for #2355.
Check List