Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve durations input format #3736

Open
DuaelFr opened this issue Dec 6, 2024 · 2 comments
Open

Improve durations input format #3736

DuaelFr opened this issue Dec 6, 2024 · 2 comments

Comments

@DuaelFr
Copy link

DuaelFr commented Dec 6, 2024

Problem Statement

In time estimates or time spent, we can input duration as a string instead of using the nice circular widget.

  1. The most frustrating thing, and I think not that hard to fix, is that we have to separate our time component with a space or it fails.
    For example, 1h 45m works just fine while 1h45m is calculated as 1m
  2. As an improvement, we could allow to input 1h45 and guess it was 45 minutes
  3. Another improvement would be to allow using floats like 1.5h

❔ Possible Solution

Improve stringToMs to:

  1. split on anything but numbers (+ dots, and commas) instead of just spaces.
  2. guess the letter if none has been provided for the current part
  3. use parseFloat instead of parseInt

⤴️ Describe alternatives you've considered

None

➕ Additional context

Might help solve #3420 and #2983

Copy link

github-actions bot commented Dec 6, 2024

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

Copy link

github-actions bot commented Dec 6, 2024

Hello there DuaelFr! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

For more open ended discussions and/or specific questions, please visit the discussions page. 💖

DuaelFr pushed a commit to DuaelFr/super-productivity that referenced this issue Dec 6, 2024
DuaelFr pushed a commit to DuaelFr/super-productivity that referenced this issue Dec 7, 2024
BanditsBacon pushed a commit to BanditsBacon/super-productivity that referenced this issue Dec 9, 2024
BanditsBacon pushed a commit to BanditsBacon/super-productivity that referenced this issue Dec 9, 2024
johannesjo added a commit that referenced this issue Dec 10, 2024
* master:
  feat: add better handling for when trying to schedule to today task to today (sarah's case)
  test: add tests for stringToMs improvements #3736
  feat: improve durations input format #3736
  Update Linux categories in electron-builder.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants