Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolkitCleaner is using deprecated API #239

Closed
mbp opened this issue Aug 17, 2023 · 5 comments · Fixed by #257
Closed

ToolkitCleaner is using deprecated API #239

mbp opened this issue Aug 17, 2023 · 5 comments · Fixed by #257

Comments

@mbp
Copy link

mbp commented Aug 17, 2023

When using the ToolkitCleaner construct:

[WARNING] aws-cdk-lib.aws_stepfunctions.StateMachineProps#definition is deprecated.
  use definitionBody: DefinitionBody.fromChainable()
  This API will be removed in the next major release.
@jogold
Copy link
Owner

jogold commented Aug 18, 2023

Hi @mbp,

Thanks for reporting this. Unfortunately I cannot change this for now since it would require all users of this construct to update to aws-cdk-lib v2.85.0.

@mbp
Copy link
Author

mbp commented Aug 21, 2023

Hi @jogold, thanks for your prompt response.

In our project, we have a policy of not using deprecated APIs, so we can be prepared for future CDK versions. Our build will fail, if using deprecated APIs. So it makes it difficult for us to upgrade to newer versions, while packages like cloudstructs is using deprecated APIs.

But I totally understand your reasoning. Do you only expect to migrate from deprecated APIs when cdk v3 comes out, or could it be sooner?

@jogold
Copy link
Owner

jogold commented Aug 29, 2023

But I totally understand your reasoning. Do you only expect to migrate from deprecated APIs when cdk v3 comes out, or could it be sooner?

It could be sooner but I haven't decided yet.

I will leave this issue open in the meantime.

@Mahdi-Malekan
Copy link

Any news on this?

@jogold
Copy link
Owner

jogold commented Sep 25, 2023

Any news on this?

Not yet, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants