New supportsCustomHeaders
property in WebSocketClient
interface
#474
Labels
breaking
A breaking change
supportsCustomHeaders
property in WebSocketClient
interface
#474
Some
WebSocketClient
implementations do not support sending custom headers in the handshake, and this cannot be implemented in Krossbow. Here are some cases where it's just not possible right now:Calling
connect()
with a non-empty headers map on these clients currently causes anIllegalArgumentException
. It would be nice to allow consumers to check up front whether the client supports custom headers.Possible implementations:
supportsCustomHeaders: Boolean
onWebSocketClient
WebSocketClient
types, one with theconnect()
method that takes aheaders
param and one that doesn't.It would also simplify tests.
The text was updated successfully, but these errors were encountered: