forked from hubotio/hubot
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
version 5. refactoring and changed the middleware interface
- Loading branch information
1 parent
144bdd8
commit 8df7531
Showing
12 changed files
with
251 additions
and
232 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| import test from 'node:test' | ||
| import assert from 'node:assert/strict' | ||
| import EventEmitter from 'node:events' | ||
|
|
||
| class InMemoryCommandQueue { | ||
| #queue = [] | ||
| constructor(){} | ||
| async enqueue(command){ | ||
| this.#queue.push(command) | ||
| } | ||
| *dequeue(){ | ||
| yield this.#queue.shift() | ||
| } | ||
| } | ||
|
|
||
| class Hubot extends EventEmitter { | ||
| #queue | ||
| #timer | ||
| constructor(state = {}){ | ||
| super() | ||
| this.#queue = new InMemoryCommandQueue() | ||
| this.events = [] | ||
| this.decisionState = state | ||
| this.listeners = new Set() | ||
| } | ||
| iterateOverQueue(){ | ||
| for(let request of this.#queue.dequeue()){ | ||
| if(!request) continue | ||
| try{ | ||
| let event = this.#handle(this.decisionState, request) | ||
| if(event) this.events.push(event) | ||
| }catch(e){ | ||
| console.error(e) | ||
| throw e | ||
| } | ||
| } | ||
| } | ||
| #handle(state, request){ | ||
| request.connection.write(request.message) | ||
| for(let listener of this.listeners){ | ||
| listener.receive(request) | ||
| } | ||
| return request | ||
| } | ||
| start(period = 1000){ | ||
| this.#timer = setInterval(this.iterateOverQueue.bind(this), period) | ||
| } | ||
| stop(){ | ||
| clearInterval(this.#timer) | ||
| } | ||
| recevieMessage(message){ | ||
| this.emit('incoming message', message) | ||
| } | ||
| addIncomingRequest(request){ | ||
| this.#queue.enqueue(request) | ||
| } | ||
| } | ||
|
|
||
| class Chat extends EventEmitter{ | ||
| #url | ||
| #protocols | ||
| #buffer = [] | ||
| constructor(url, protocols){ | ||
| super() | ||
| this.#url = url | ||
| this.#protocols = protocols | ||
| } | ||
| addEventListener(eventName, listener){ | ||
| this.addListener(eventName, listener) | ||
| } | ||
| removeEventListener(eventName, listener){ | ||
| this.removeListener(eventName, listener) | ||
| } | ||
| sendMessage(message){ | ||
| this.emit('message', this, message) | ||
| } | ||
| write(data){ | ||
| console.log('writing data', data) | ||
| this.#buffer.push(data) | ||
| } | ||
| *read(){ | ||
| yield this.#buffer.shift() | ||
| } | ||
|
|
||
| } | ||
| class IncomingRequest { | ||
| constructor(connection, message){ | ||
| this.connection = connection | ||
| this.message = message | ||
| } | ||
| } | ||
| await test('Explore simplifying the software design of Hubot', async (t)=>{ | ||
| await t.test('Decouple receiving a message from responding to a message', async ()=> { | ||
| const hubot = new Hubot() | ||
| hubot.listeners.add({ | ||
| receive(request){ | ||
| if(!/yo/.test(request.message)) return | ||
| console.log('listening to ', request.message) | ||
| } | ||
| }) | ||
| hubot.start() | ||
| const chat = new Chat('ws://localhost/testing') | ||
| chat.addEventListener('message', (connection, message)=>{ | ||
| hubot.addIncomingRequest(new IncomingRequest(connection, message)) | ||
| }) | ||
| chat.sendMessage('Hi') | ||
| let data = null | ||
| await new Promise((resolve, reject)=>{ | ||
| let timer = setInterval(()=>{ | ||
| data = chat.read().next().value | ||
| if(!data) return | ||
| clearInterval(timer) | ||
| hubot.stop() | ||
| assert.deepEqual(data, 'Hi') | ||
| resolve() | ||
| }, 100) | ||
| }) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.