Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moon_phase_face: Make alarm long-press reset to current day. #316

Merged
merged 1 commit into from
Mar 17, 2024
Merged

moon_phase_face: Make alarm long-press reset to current day. #316

merged 1 commit into from
Mar 17, 2024

Conversation

WesleyAC
Copy link
Collaborator

@WesleyAC WesleyAC commented Nov 3, 2023

No description provided.

@WesleyAC WesleyAC added the tested-on-hw This feature or pull request has been tested on a physical watch label Jan 23, 2024
matheusmoreira
matheusmoreira approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@matheusmoreira matheusmoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems correct to me. This is a much needed feature. I tried to do this when I got my watch and was confused when it didn't work.

matheusmoreira added a commit to matheusmoreira/sensor-watch that referenced this pull request Mar 5, 2024
@matheusmoreira
Merge branch 'moon-phase-face-long-press-reset'
4691250 
Makes a long press of the ALARM button reset the face to current day.

Tested-by: Wesley Aptekar-Cassels <[email protected]>
Reviewed-by: Matheus Afonso Martins Moreira <[email protected]>
Signed-off-by: Matheus Afonso Martins Moreira <[email protected]>
GitHub-Pull-Request: joeycastillo#316
matheusmoreira added a commit to matheusmoreira/sensor-watch that referenced this pull request Mar 5, 2024
@matheusmoreira
Merge branch 'moon-phase-face-long-press-reset'
e1d6c30 
Makes a long press of the ALARM button reset the face to current day.

Tested-by: Wesley Aptekar-Cassels <[email protected]>
Reviewed-by: Matheus Afonso Martins Moreira <[email protected]>
Signed-off-by: Matheus Afonso Martins Moreira <[email protected]>
GitHub-Pull-Request: joeycastillo#316
matheusmoreira added a commit to matheusmoreira/sensor-watch that referenced this pull request Mar 5, 2024
@matheusmoreira
Merge branch 'moon-phase-face-long-press-reset'
f63b884 
Makes a long press of the ALARM button reset the face to current day.

Tested-by: Wesley Aptekar-Cassels <[email protected]>
Reviewed-by: Matheus Afonso Martins Moreira <[email protected]>
Signed-off-by: Matheus Afonso Martins Moreira <[email protected]>
GitHub-Pull-Request: joeycastillo#316
matheusmoreira added a commit to matheusmoreira/sensor-watch that referenced this pull request Mar 5, 2024
@matheusmoreira
Merge branch 'moon-phase-face-long-press-reset'
7a54281 
Makes a long press of the ALARM button reset the face to current day.

Tested-by: Wesley Aptekar-Cassels <[email protected]>
Reviewed-by: Matheus Afonso Martins Moreira <[email protected]>
Signed-off-by: Matheus Afonso Martins Moreira <[email protected]>
GitHub-Pull-Request: joeycastillo#316
@matheusmoreira
Copy link
Collaborator

Am now running this code on real hardware. Works well, no issues.

@matheusmoreira matheusmoreira mentioned this pull request Mar 12, 2024
Merged
@theAlexes theAlexes merged commit 7208df1 into joeycastillo:main Mar 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusmoreira matheusmoreira matheusmoreira approved these changes

Assignees
No one assigned
Labels
tested-on-hw This feature or pull request has been tested on a physical watch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WesleyAC @matheusmoreira @theAlexes