write the metadata file once after refreshing all flags #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DelayedMetadataSerializer works excellently during message download, but the FlagRefresher uses Serializer without any batching or transaction, causing the metadata file to be written for each message. For my backup of ~50k messages, this produces a rather large amount of disk writes (~20GB for INBOX alone).
I've updated the FlagRefresher to do the refresh work inside a Serializer transaction, which I've implemented to do transactions on both mbox and imap metadata.
In my testing this makes a incremental mirror backup take < 1 min with almost no disk writes.