console: add Symbol.toStringTag property

Add Symbol.toStringTag property to console object to follow WPT changes Update WPT status of console and the repl test case Refs: web-platform-tests/wpt#24717 PR-URL: nodejs#35399 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
joesepi · Oct 22, 2020 · ffcc985 · ffcc985
1 parent ab22657
commit ffcc985
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -19,6 +19,7 @@ const {
   ReflectOwnKeys,
   Symbol,
   SymbolHasInstance,
+  SymbolToStringTag,
   WeakMap,
 } = primordials;
 
@@ -233,6 +234,12 @@ ObjectDefineProperties(Console.prototype, {
           ...consolePropAttributes,
           value: groupIndentation
         },
+        [SymbolToStringTag]: {
+          writable: false,
+          enumerable: false,
+          configurable: true,
+          value: 'console'
+        }
       });
     }
   },

diff --git a/test/parallel/test-repl.js b/test/parallel/test-repl.js
@@ -757,7 +757,7 @@ const errorTests = [
   {
     send: 'console',
     expect: [
-      '{',
+      'Object [console] {',
       '  log: [Function: log],',
       '  warn: [Function: warn],',
       '  dir: [Function: dir],',

diff --git a/test/wpt/status/console.json b/test/wpt/status/console.json
@@ -1,8 +1,5 @@
 {
   "idlharness.any.js": {
     "fail": ".table, .dir and .timeLog parameter lengths are wrong"
-  },
-  "console-namespace-object-class-string.any.js": {
-    "fail": "TODO: https://github.com/web-platform-tests/wpt/pull/24717"
   }
 }