Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JsSrc2Cpg] : Increase robustness of Js frontend #5282

Merged
merged 3 commits into from
Feb 5, 2025
Merged

[JsSrc2Cpg] : Increase robustness of Js frontend #5282

merged 3 commits into from
Feb 5, 2025

Conversation

khemrajrathore
Copy link
Contributor

The PR have the following changes

  • In case of failure in AST Gen step, we should continue with partial result at that time
  • The exclusion regex should work and only send files to AST Gen which are not excluded by the exclusion rule

@max-leuthaeuser
Copy link
Contributor

This is not needed at all. astgen already respects exclusions since joernio/astgen#24 and jssrc2cpg passes them as well: https://github.com/joernio/joern/blob/master/joern-cli/frontends/jssrc2cpg/src/main/scala/io/joern/jssrc2cpg/utils/AstGenRunner.scala#L180

@khemrajrathore
Copy link
Contributor Author

Looks like this was added recently in November, let me revert this part and keep only the partial result part

@khemrajrathore
Copy link
Contributor Author

Can we get this merged?

@max-leuthaeuser max-leuthaeuser merged commit cd84cd9 into joernio:master Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-leuthaeuser max-leuthaeuser max-leuthaeuser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khemrajrathore @max-leuthaeuser @PallaviShreshtha