[pysrc2cpg] Fix captured variable linking into class scopes. #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linking of captured variables was not yet working if variables from outside of a class have been captured into methods of a class. This was the case because of a possible name clashes between those captured variables and variables inside of the class body methods. To avoid such clashes captures variables get a `<captured>` prefix inside the class body methods. This solves a long standing issue where data flows via such captured variables were not found.
ml86
force-pushed
the
markus/pysrc2cpgFixes
branch
from
8055a35 to
d346f32
Compare
maltek
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linking of captured variables was not yet working if variables from
outside of a class have been captured into methods of a class.
This was the case because of a possible name clashes between those
captured variables and variables inside of the class body methods.
To avoid such clashes captures variables get a
<captured>prefixinside the class body methods.
This solves a long standing issue where data flows via such captured
variables were not found.